Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow for images in random order #140

Merged
merged 1 commit into from
Sep 12, 2020
Merged

allow for images in random order #140

merged 1 commit into from
Sep 12, 2020

Conversation

call-me-matt
Copy link

@call-me-matt call-me-matt commented Jul 30, 2020 •
edited
Loading

fixes #133

call-me-matt
call-me-matt commented Jul 30, 2020
View reviewed changes
js/renderer.js
currentImageIndex = images.length;
loadImage(true, 0);
currentImageIndex = 0;
loadImage(false, 0, true);
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please verify this is ok. Need to jump directly to a new picture, as the other logic won't work in random order.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it has the side-effect that when new pictures come in while in pause, the picture changes to the latest one? (To be investigated)

@LukeSkywalker92 LukeSkywalker92 requested a review from gegu August 18, 2020 13:48
@gegu gegu changed the base branch from master to develop September 12, 2020 14:07
gegu
gegu approved these changes Sep 12, 2020
View reviewed changes
Copy link
Collaborator

@gegu gegu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the extension fits.

I merge it into the develop branch.

We had a problem that the master was before the develop branch, which I fixed.
In the future we should stick to the workflow, otherwise the merges will get complicated.

@gegu gegu merged commit 0b391f6 into LukeSkywalker92:develop Sep 12, 2020
@call-me-matt
Copy link
Author

Great! Thank you

@call-me-matt call-me-matt deleted the feature/random-order branch September 12, 2020 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gegu gegu gegu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Random Picture View
2 participants
@call-me-matt @gegu